Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noto Sans Sundanese: Version 2.004 added #6401

Closed
wants to merge 1 commit into from
Closed

Noto Sans Sundanese: Version 2.004 added #6401

wants to merge 1 commit into from
+3 −3

Conversation

simoncozens
Copy link
Collaborator

176ca96: [gftools-packager] Noto Sans Sundanese: Version 2.004 added

@simoncozens
Copy link
Collaborator Author 

This release:

* Ensures spacing marks are adequately spaced (#3)
* Moves anusvara adjacent to base (#1)

@github-actions
Copy link

Fontbakery report

Fontbakery version: 0.8.13

[1] Family checks
ℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)

  • ℹ INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[13] NotoSansSundanese[wght].ttf
🔥 FAIL: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • 🔥 FAIL The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́ [code: soft-dotted]

⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)

  • ⚠ WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, tifinagh, canadian-aboriginal

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal

  • U+0300 COMBINING GRAVE ACCENT: try adding one of: old-permic, coptic, cherokee, tai-le

  • U+0301 COMBINING ACUTE ACCENT: try adding one of: cherokee, coptic, tifinagh, osage, tai-le

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: math, tifinagh, coptic, cherokee

  • U+0303 COMBINING TILDE: try adding one of: math, syriac, glagolitic

  • U+0304 COMBINING MACRON: try adding one of: cherokee, gothic, coptic, tifinagh, osage, caucasian-albanian, syriac

  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
    5 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, sundanese [code: unreachable-subsetting]

⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • ⚠ WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • ⚠ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)

  • ⚠ WARN The following glyphs could not be reached by codepoint or substitution rules:

    • uni00A0.1
      [code: unreachable-glyphs]
⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • ⚠ WARN The most common width is 572 among a set of 6 math glyphs.
    The following math glyphs have a different width, though:

Width = 322:
minus
[code: width-outliers]

ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • ℹ INFO Hinting filesize impact:
ofl/notosanssundanese/NotoSansSundanese[wght].ttf
Dehinted Size 60.6kb
Hinted Size 60.6kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • ℹ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.004'] [code: version-not-detected]
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • ℹ INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • ℹ INFO Version string is: "Version 2.004"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)

  • ℹ INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • ℹ INFO ofl/notosanssundanese [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 1 5 45 8 187 0
0% 0% 2% 18% 3% 76% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@simoncozens simoncozens mentioned this pull request Jul 18, 2023
Closed
@RosaWagner
Copy link
Contributor

@simoncozens The space shift is part of the upgrade right?
diffbrowsers_text-Linux-5 15 0-1039-azure-x86_64-with-glibc2 35_chrome_114 0 5735 106

@RosaWagner RosaWagner added the -- Needs confirmation from upstream or onboarder label Sep 7, 2023
@RosaWagner RosaWagner mentioned this pull request Sep 7, 2023
Closed
29 tasks
@simoncozens
Copy link
Collaborator Author

It is expected, but it's not correct. My fix to notofonts/sundanese#3 was wrong, so now we have a new issue (notofonts/sundanese#7). We may as well close this PR and I'll fix the font and make a new one.

@simoncozens simoncozens closed this Sep 7, 2023
@simoncozens simoncozens deleted the gftools_packager_ofl_notosanssundanese branch September 7, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
-- Needs confirmation from upstream or onboarder I Font Upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simoncozens @RosaWagner